r8169: remove unneeded call to __rtl8169_set_features in rtl_open
authorHeiner Kallweit <hkallweit1@gmail.com>
Sat, 28 Apr 2018 20:19:08 +0000 (22:19 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 30 Apr 2018 13:38:19 +0000 (09:38 -0400)
RxChkSum and RxVlan aren't touched outside __rtl8169_set_features
(except in probe), so they are always in sync with dev->features.
And the RxConfig flags are set in rtl_set_rx_mode() which is
called via dev_set_rx_mode() from __dev_open().
Therefore we can safely remove this call.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/realtek/r8169.c

index a5d00ee942450b10fa0dba0951955b1aba9de304..d2656224fc498833f48c2c276754c4bb8b7f8f94 100644 (file)
@@ -7637,8 +7637,6 @@ static int rtl_open(struct net_device *dev)
 
        rtl8169_init_phy(dev, tp);
 
-       __rtl8169_set_features(dev, dev->features);
-
        rtl_pll_power_up(tp);
 
        rtl_hw_start(tp);