mwifiex: 11n_rxreorder: Use setup_timer
authorJulia Lawall <Julia.Lawall@lip6.fr>
Fri, 26 Dec 2014 14:35:57 +0000 (15:35 +0100)
committerKalle Valo <kvalo@codeaurora.org>
Wed, 7 Jan 2015 08:45:15 +0000 (10:45 +0200)
Convert a call to init_timer and accompanying intializations of
the timer's data and function fields to a call to setup_timer.

A simplified version of the semantic match that fixes this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression t,f,d;
@@

-init_timer(&t);
+setup_timer(&t,f,d);
-t.function = f;
-t.data = d;
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/mwifiex/11n_rxreorder.c

index d73fda312c87a53278b3fda1fc5c3fb521a2b805..f33dc81c52285c4cfc94c6b2a9a31cf75ae03c6c 100644 (file)
@@ -391,10 +391,8 @@ mwifiex_11n_create_rx_reorder_tbl(struct mwifiex_private *priv, u8 *ta,
        new_node->timer_context.priv = priv;
        new_node->timer_context.timer_is_set = false;
 
-       init_timer(&new_node->timer_context.timer);
-       new_node->timer_context.timer.function = mwifiex_flush_data;
-       new_node->timer_context.timer.data =
-                       (unsigned long) &new_node->timer_context;
+       setup_timer(&new_node->timer_context.timer, mwifiex_flush_data,
+                   (unsigned long)&new_node->timer_context);
 
        for (i = 0; i < win_size; ++i)
                new_node->rx_reorder_ptr[i] = NULL;