Avoid duplicated iteration over services when announcing

In function service_announce_services we iterate over services and
handle every single one so calling service_reply which also iterates
doesn't make sense.

In simple cases it was just wasting CPU cycles. We got service, we were
passing its name and we were looking for it again comparing names.
In cases with one service available on few different ports it was worse.
For every iterated service we were announcing that one and all other
sharing the same name. It resulted in sending n^2 records.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Acked-by: John Crispin <john@phrozen.org>

diff --git a/service.c b/service.c
index 182b2b2bfaa4496cc35eedecf570f1df20127acf..bb87aff954aa0cc7dd95f5a90ecd5a2b5a2b7daa 100644 (file)
--- a/service.c
+++ b/service.c
@@ -179,7 +179,7 @@ service_announce_services(struct interface *iface, const char *service, int ttl)
                        else
                                dns_send_answer(iface, sdudp);
                }
-               service_reply(iface, s->service, ttl);
+               service_reply_single(iface, s, ttl, 0);
        }
 }