ext4: fix warning inside ext4_convert_unwritten_extents_endio
authorRakesh Pandit <rakesh@tuxera.com>
Fri, 23 Aug 2019 02:53:46 +0000 (22:53 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Fri, 23 Aug 2019 02:53:46 +0000 (22:53 -0400)
Really enable warning when CONFIG_EXT4_DEBUG is set and fix missing
first argument.  This was introduced in commit ff95ec22cd7f ("ext4:
add warning to ext4_convert_unwritten_extents_endio") and splitting
extents inside endio would trigger it.

Fixes: ff95ec22cd7f ("ext4: add warning to ext4_convert_unwritten_extents_endio")
Signed-off-by: Rakesh Pandit <rakesh@tuxera.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
fs/ext4/extents.c

index 0620d495fd8a732e4e193da24aca5cb745086af8..fb0f99dc8c223eafb5dad27de834604ad719e27e 100644 (file)
@@ -3859,8 +3859,8 @@ static int ext4_convert_unwritten_extents_endio(handle_t *handle,
         * illegal.
         */
        if (ee_block != map->m_lblk || ee_len > map->m_len) {
-#ifdef EXT4_DEBUG
-               ext4_warning("Inode (%ld) finished: extent logical block %llu,"
+#ifdef CONFIG_EXT4_DEBUG
+               ext4_warning(inode->i_sb, "Inode (%ld) finished: extent logical block %llu,"
                             " len %u; IO logical block %llu, len %u",
                             inode->i_ino, (unsigned long long)ee_block, ee_len,
                             (unsigned long long)map->m_lblk, map->m_len);