drm/i915: Test creation of VMA
authorChris Wilson <chris@chris-wilson.co.uk>
Mon, 13 Feb 2017 17:15:45 +0000 (17:15 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Mon, 13 Feb 2017 20:46:40 +0000 (20:46 +0000)
Simple test to exercise creation and lookup of VMA within an object.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20170213171558.20942-34-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/i915_vma.c
drivers/gpu/drm/i915/selftests/i915_mock_selftests.h
drivers/gpu/drm/i915/selftests/i915_vma.c [new file with mode: 0644]

index e75494c1ef52fb482a00f28f92af091ed0859915..e6c565fd6e61960c5c55aab9d188dfdaa460f929 100644 (file)
@@ -690,3 +690,6 @@ destroy:
        return 0;
 }
 
+#if IS_ENABLED(CONFIG_DRM_I915_SELFTEST)
+#include "selftests/i915_vma.c"
+#endif
index 955a4d6ccdaf8152f6d57afba6e54310ff4ac5d9..b450eab7e6e1da137e4037681273f91884977a5f 100644 (file)
@@ -15,3 +15,4 @@ selftest(breadcrumbs, intel_breadcrumbs_mock_selftests)
 selftest(requests, i915_gem_request_mock_selftests)
 selftest(objects, i915_gem_object_mock_selftests)
 selftest(dmabuf, i915_gem_dmabuf_mock_selftests)
+selftest(vma, i915_vma_mock_selftests)
diff --git a/drivers/gpu/drm/i915/selftests/i915_vma.c b/drivers/gpu/drm/i915/selftests/i915_vma.c
new file mode 100644 (file)
index 0000000..eb794fc
--- /dev/null
@@ -0,0 +1,224 @@
+/*
+ * Copyright © 2016 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ *
+ */
+
+#include <linux/prime_numbers.h>
+
+#include "../i915_selftest.h"
+
+#include "mock_gem_device.h"
+#include "mock_context.h"
+
+static bool assert_vma(struct i915_vma *vma,
+                      struct drm_i915_gem_object *obj,
+                      struct i915_gem_context *ctx)
+{
+       bool ok = true;
+
+       if (vma->vm != &ctx->ppgtt->base) {
+               pr_err("VMA created with wrong VM\n");
+               ok = false;
+       }
+
+       if (vma->size != obj->base.size) {
+               pr_err("VMA created with wrong size, found %llu, expected %zu\n",
+                      vma->size, obj->base.size);
+               ok = false;
+       }
+
+       if (vma->ggtt_view.type != I915_GGTT_VIEW_NORMAL) {
+               pr_err("VMA created with wrong type [%d]\n",
+                      vma->ggtt_view.type);
+               ok = false;
+       }
+
+       return ok;
+}
+
+static struct i915_vma *
+checked_vma_instance(struct drm_i915_gem_object *obj,
+                    struct i915_address_space *vm,
+                    struct i915_ggtt_view *view)
+{
+       struct i915_vma *vma;
+       bool ok = true;
+
+       vma = i915_vma_instance(obj, vm, view);
+       if (IS_ERR(vma))
+               return vma;
+
+       /* Manual checks, will be reinforced by i915_vma_compare! */
+       if (vma->vm != vm) {
+               pr_err("VMA's vm [%p] does not match request [%p]\n",
+                      vma->vm, vm);
+               ok = false;
+       }
+
+       if (i915_is_ggtt(vm) != i915_vma_is_ggtt(vma)) {
+               pr_err("VMA ggtt status [%d] does not match parent [%d]\n",
+                      i915_vma_is_ggtt(vma), i915_is_ggtt(vm));
+               ok = false;
+       }
+
+       if (i915_vma_compare(vma, vm, view)) {
+               pr_err("i915_vma_compare failed with create parmaters!\n");
+               return ERR_PTR(-EINVAL);
+       }
+
+       if (i915_vma_compare(vma, vma->vm,
+                            i915_vma_is_ggtt(vma) ? &vma->ggtt_view : NULL)) {
+               pr_err("i915_vma_compare failed with itself\n");
+               return ERR_PTR(-EINVAL);
+       }
+
+       if (!ok) {
+               pr_err("i915_vma_compare failed to detect the difference!\n");
+               return ERR_PTR(-EINVAL);
+       }
+
+       return vma;
+}
+
+static int create_vmas(struct drm_i915_private *i915,
+                      struct list_head *objects,
+                      struct list_head *contexts)
+{
+       struct drm_i915_gem_object *obj;
+       struct i915_gem_context *ctx;
+       int pinned;
+
+       list_for_each_entry(obj, objects, st_link) {
+               for (pinned = 0; pinned <= 1; pinned++) {
+                       list_for_each_entry(ctx, contexts, link) {
+                               struct i915_address_space *vm =
+                                       &ctx->ppgtt->base;
+                               struct i915_vma *vma;
+                               int err;
+
+                               vma = checked_vma_instance(obj, vm, NULL);
+                               if (IS_ERR(vma))
+                                       return PTR_ERR(vma);
+
+                               if (!assert_vma(vma, obj, ctx)) {
+                                       pr_err("VMA lookup/create failed\n");
+                                       return -EINVAL;
+                               }
+
+                               if (!pinned) {
+                                       err = i915_vma_pin(vma, 0, 0, PIN_USER);
+                                       if (err) {
+                                               pr_err("Failed to pin VMA\n");
+                                               return err;
+                                       }
+                               } else {
+                                       i915_vma_unpin(vma);
+                               }
+                       }
+               }
+       }
+
+       return 0;
+}
+
+static int igt_vma_create(void *arg)
+{
+       struct drm_i915_private *i915 = arg;
+       struct drm_i915_gem_object *obj, *on;
+       struct i915_gem_context *ctx, *cn;
+       unsigned long num_obj, num_ctx;
+       unsigned long no, nc;
+       IGT_TIMEOUT(end_time);
+       LIST_HEAD(contexts);
+       LIST_HEAD(objects);
+       int err;
+
+       /* Exercise creating many vma amonst many objections, checking the
+        * vma creation and lookup routines.
+        */
+
+       no = 0;
+       for_each_prime_number(num_obj, ULONG_MAX - 1) {
+               for (; no < num_obj; no++) {
+                       obj = i915_gem_object_create_internal(i915, PAGE_SIZE);
+                       if (IS_ERR(obj))
+                               goto out;
+
+                       list_add(&obj->st_link, &objects);
+               }
+
+               nc = 0;
+               for_each_prime_number(num_ctx, MAX_CONTEXT_HW_ID) {
+                       for (; nc < num_ctx; nc++) {
+                               ctx = mock_context(i915, "mock");
+                               if (!ctx)
+                                       goto out;
+
+                               list_move(&ctx->link, &contexts);
+                       }
+
+                       err = create_vmas(i915, &objects, &contexts);
+                       if (err)
+                               goto out;
+
+                       if (igt_timeout(end_time,
+                                       "%s timed out: after %lu objects in %lu contexts\n",
+                                       __func__, no, nc))
+                               goto end;
+               }
+
+               list_for_each_entry_safe(ctx, cn, &contexts, link)
+                       mock_context_close(ctx);
+       }
+
+end:
+       /* Final pass to lookup all created contexts */
+       err = create_vmas(i915, &objects, &contexts);
+out:
+       list_for_each_entry_safe(ctx, cn, &contexts, link)
+               mock_context_close(ctx);
+
+       list_for_each_entry_safe(obj, on, &objects, st_link)
+               i915_gem_object_put(obj);
+       return err;
+}
+
+int i915_vma_mock_selftests(void)
+{
+       static const struct i915_subtest tests[] = {
+               SUBTEST(igt_vma_create),
+       };
+       struct drm_i915_private *i915;
+       int err;
+
+       i915 = mock_gem_device();
+       if (!i915)
+               return -ENOMEM;
+
+       mutex_lock(&i915->drm.struct_mutex);
+       err = i915_subtests(tests, i915);
+       mutex_unlock(&i915->drm.struct_mutex);
+
+       drm_dev_unref(&i915->drm);
+       return err;
+}
+