projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
b2cbf2e
)
tg3: remove redundant NULL test before release_firmware() call
author
Jesper Juhl
<jj@chaosbits.net>
Mon, 9 Apr 2012 20:50:15 +0000
(22:50 +0200)
committer
Jiri Kosina
<jkosina@suse.cz>
Mon, 30 Apr 2012 11:17:53 +0000
(13:17 +0200)
There is no need to test for a NULL pointer before calling
release_firmware - the function does that on its own.
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/net/ethernet/broadcom/tg3.c
patch
|
blob
|
history
diff --git
a/drivers/net/ethernet/broadcom/tg3.c
b/drivers/net/ethernet/broadcom/tg3.c
index 062ac333fde60be0732572f39e0a7a46335da499..9fbf73e41e30f5564822b2adc66bfce067efa6a9 100644
(file)
--- a/
drivers/net/ethernet/broadcom/tg3.c
+++ b/
drivers/net/ethernet/broadcom/tg3.c
@@
-15842,8
+15842,7
@@
static void __devexit tg3_remove_one(struct pci_dev *pdev)
if (dev) {
struct tg3 *tp = netdev_priv(dev);
- if (tp->fw)
- release_firmware(tp->fw);
+ release_firmware(tp->fw);
tg3_reset_task_cancel(tp);