x86: ptrace FLAG_MASK cleanup
authorRoland McGrath <roland@redhat.com>
Wed, 30 Jan 2008 12:31:01 +0000 (13:31 +0100)
committerIngo Molnar <mingo@elte.hu>
Wed, 30 Jan 2008 12:31:01 +0000 (13:31 +0100)
This cleans up the FLAG_MASK macro to use symbolic constants instead of a
magic number.

Signed-off-by: Roland McGrath <roland@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
arch/x86/kernel/ptrace.c

index fed83d06613510a07ed1b7ab84efc521dc0d6074..b71226d653ed63450981578c4da76afec938fd2e 100644 (file)
 
 /*
  * Determines which flags the user has access to [1 = access, 0 = no access].
- * Prohibits changing ID(21), VIP(20), VIF(19), VM(17), NT(14), IOPL(12-13), IF(9).
- * Also masks reserved bits (31-22, 15, 5, 3, 1).
  */
-#define FLAG_MASK 0x00050dd5
+#define FLAG_MASK_32           ((unsigned long)                        \
+                                (X86_EFLAGS_CF | X86_EFLAGS_PF |       \
+                                 X86_EFLAGS_AF | X86_EFLAGS_ZF |       \
+                                 X86_EFLAGS_SF | X86_EFLAGS_TF |       \
+                                 X86_EFLAGS_DF | X86_EFLAGS_OF |       \
+                                 X86_EFLAGS_RF | X86_EFLAGS_AC))
+
+#define FLAG_MASK              FLAG_MASK_32
 
 static long *pt_regs_access(struct pt_regs *regs, unsigned long regno)
 {