MIPS: KVM: Report more accurate CP0_Config fields to guest
authorJames Hogan <james.hogan@imgtec.com>
Wed, 15 Jun 2016 18:30:00 +0000 (19:30 +0100)
committerPaolo Bonzini <pbonzini@redhat.com>
Wed, 15 Jun 2016 21:58:42 +0000 (23:58 +0200)
Initialise the guest's CP0_Config register with a few more bits of
information from the host. The BE bit should be set on big endian
machines, the VI bit should be set on machines with a virtually tagged
instruction cache, and the reported architecture revision should match
that of the host (since we won't support emulating pre-r6 instruction
encodings on r6 or vice versa).

Signed-off-by: James Hogan <james.hogan@imgtec.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Radim Krčmář <rkrcmar@redhat.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
Cc: kvm@vger.kernel.org
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
arch/mips/kvm/trap_emul.c

index eb191c4612bb461b5550ee7b5a7ad9599debdcff..1dc003ddca913f48f047abac90cdf664859f78b9 100644 (file)
@@ -426,7 +426,7 @@ static int kvm_trap_emul_vcpu_init(struct kvm_vcpu *vcpu)
 static int kvm_trap_emul_vcpu_setup(struct kvm_vcpu *vcpu)
 {
        struct mips_coproc *cop0 = vcpu->arch.cop0;
-       u32 config1;
+       u32 config, config1;
        int vcpu_id = vcpu->vcpu_id;
 
        /*
@@ -434,10 +434,20 @@ static int kvm_trap_emul_vcpu_setup(struct kvm_vcpu *vcpu)
         * guest will come up as expected, for now we simulate a MIPS 24kc
         */
        kvm_write_c0_guest_prid(cop0, 0x00019300);
-       /* Have config1, Cacheable, noncoherent, write-back, write allocate */
-       kvm_write_c0_guest_config(cop0, MIPS_CONF_M | (0x3 << CP0C0_K0) |
-                                 (0x1 << CP0C0_AR) |
-                                 (MMU_TYPE_R4000 << CP0C0_MT));
+       /*
+        * Have config1, Cacheable, noncoherent, write-back, write allocate.
+        * Endianness, arch revision & virtually tagged icache should match
+        * host.
+        */
+       config = read_c0_config() & MIPS_CONF_AR;
+       config |= MIPS_CONF_M | (0x3 << CP0C0_K0) |
+               (MMU_TYPE_R4000 << CP0C0_MT);
+#ifdef CONFIG_CPU_BIG_ENDIAN
+       config |= CONF_BE;
+#endif
+       if (cpu_has_vtag_icache)
+               config |= MIPS_CONF_VI;
+       kvm_write_c0_guest_config(cop0, config);
 
        /* Read the cache characteristics from the host Config1 Register */
        config1 = (read_c0_config1() & ~0x7f);