drm/vgem: Simplify dumb_map
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 30 Mar 2016 09:40:49 +0000 (11:40 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 20 Apr 2016 10:58:17 +0000 (12:58 +0200)
The offset manager already checks for existing offsets internally,
while holding suitable locks. We can drop this check.

v2: Fix title (Emil).

Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1459330852-27668-11-git-send-email-daniel.vetter@ffwll.ch
drivers/gpu/drm/vgem/vgem_drv.c

index c503a840fd889fd5cea318a60266c21159eda9ca..f3ee1c41da1ed6f013f3762e3fb554e0ce6291a9 100644 (file)
@@ -208,11 +208,9 @@ int vgem_gem_dumb_map(struct drm_file *file, struct drm_device *dev,
                goto unlock;
        }
 
-       if (!drm_vma_node_has_offset(&obj->vma_node)) {
-               ret = drm_gem_create_mmap_offset(obj);
-               if (ret)
-                       goto unref;
-       }
+       ret = drm_gem_create_mmap_offset(obj);
+       if (ret)
+               goto unref;
 
        BUG_ON(!obj->filp);