drm/doc: More fine-tuning on userspace review requirements
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 21 May 2019 08:48:49 +0000 (10:48 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Mon, 3 Jun 2019 07:39:24 +0000 (09:39 +0200)
With Eric's patch

commit ba6e798ecf320716780bb6a6088a8d17dcba1d49
Author: Eric Anholt <eric@anholt.net>
Date:   Wed Apr 24 11:56:17 2019 -0700

    drm/doc: Document expectation that userspace review looks at kernel uAPI.

there's been concerns raised that we expect userspace people to do
in-depth kernel patch review. That's not reasonable, same way kernel
people can't review all the userspace we have. Try to clarify
expectations a bit more.

Cc: Eric Anholt <eric@anholt.net>
Cc: Pekka Paalanen <ppaalanen@gmail.com>
Cc: contact@emersion.fr
Cc: wayland-devel@lists.freedesktop.org
Acked-by: Eric Anholt <eric@anholt.net>
Reviewed-by: Simon Ser <contact@emersion.fr>
Reviewed-by: Pekka Paalanen <pekka.paalanen@collabora.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190521084849.27452-1-daniel.vetter@ffwll.ch
Documentation/gpu/drm-uapi.rst

index 05874d09820c25d6a2708bfbbe01e2daa2c440bd..f368e58fb727b1f63fe17f728bc72cc2ae81cdb9 100644 (file)
@@ -85,9 +85,9 @@ leads to a few additional requirements:
 - The userspace side must be fully reviewed and tested to the standards of that
   userspace project. For e.g. mesa this means piglit testcases and review on the
   mailing list. This is again to ensure that the new interface actually gets the
-  job done.  The userspace-side reviewer should also provide at least an
-  Acked-by on the kernel uAPI patch indicating that they've looked at how the
-  kernel side is implementing the new feature being used.
+  job done.  The userspace-side reviewer should also provide an Acked-by on the
+  kernel uAPI patch indicating that they believe the proposed uAPI is sound and
+  sufficiently documented and validated for userspace's consumption.
 
 - The userspace patches must be against the canonical upstream, not some vendor
   fork. This is to make sure that no one cheats on the review and testing