Input: auo-pixcir-ts - switch to using devm_add_action_or_reset()
authorFuqian Huang <huangfq.daxian@gmail.com>
Sat, 13 Jul 2019 08:05:19 +0000 (01:05 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Sat, 13 Jul 2019 08:43:12 +0000 (01:43 -0700)
devm_add_action_or_reset() is introduced as a helper function which
internally calls devm_add_action(). If devm_add_action() fails
then it will execute the action mentioned and return the error code.
This reduce source code size (avoid writing the action twice)
and reduce the likelyhood of bugs.

Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/touchscreen/auo-pixcir-ts.c

index df8ca856393b60ac56ec60e556c3284d4dcd669a..02507c0b664172cd050a1b570c3997c4bbc2bf84 100644 (file)
@@ -612,9 +612,8 @@ static int auo_pixcir_probe(struct i2c_client *client,
                return error;
        }
 
-       error = devm_add_action(&client->dev, auo_pixcir_reset, ts);
+       error = devm_add_action_or_reset(&client->dev, auo_pixcir_reset, ts);
        if (error) {
-               auo_pixcir_reset(ts);
                dev_err(&client->dev, "failed to register reset action, %d\n",
                        error);
                return error;