drm: atmel-hlcdc: Use __drm_atomic_helper_plane_reset instead of copying the logic
authorAlexandru Gheorghe <alexandru-cosmin.gheorghe@arm.com>
Sat, 4 Aug 2018 16:15:24 +0000 (17:15 +0100)
committerAlexandru Gheorghe <alexandru-cosmin.gheorghe@arm.com>
Mon, 6 Aug 2018 10:41:49 +0000 (11:41 +0100)
A new helper function(__drm_atomic_helper_plane_reset) has been added
for linking a plane with its state and resetting the core
properties(alpha, rotation, etc.) to their default values.
Use that instead of duplicating the logic.

__drm_atomic_helper_plane_reset initializes the alpha property to its
max value, which is defined by the drm core as DRM_BLEND_ALPHA_OPAQUE,
so nothing changes regarding the alpha value.

Acked-by: Boris Brezillon <boris.brezillon@bootlin.com>
Signed-off-by: Alexandru Gheorghe <alexandru-cosmin.gheorghe@arm.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180804161530.12275-5-alexandru-cosmin.gheorghe@arm.com
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c

index 04440064b9b7baaeaec4a9d19d48a33ed2b5dbdb..9330a076e15a564a08fedba253cd69fbfc33b94c 100644 (file)
@@ -942,10 +942,7 @@ static void atmel_hlcdc_plane_reset(struct drm_plane *p)
                                "Failed to allocate initial plane state\n");
                        return;
                }
-
-               p->state = &state->base;
-               p->state->alpha = DRM_BLEND_ALPHA_OPAQUE;
-               p->state->plane = p;
+               __drm_atomic_helper_plane_reset(p, &state->base);
        }
 }