isdn: hisax: Fix pnp_irq's error checking for setup_diva_isapnp
authorArvind Yadav <arvind.yadav.cs@gmail.com>
Thu, 16 Nov 2017 04:27:20 +0000 (09:57 +0530)
committerDavid S. Miller <davem@davemloft.net>
Thu, 16 Nov 2017 13:31:15 +0000 (22:31 +0900)
The pnp_irq() function returns -1 if an error occurs.
pnp_irq() error checking for zero is not correct.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/isdn/hisax/diva.c

index 38bdd3f7b9600a4506a7c5d46d838780016fc65c..d23df7a7784df324d63567bd481e109d396d95ce 100644 (file)
@@ -1093,7 +1093,7 @@ static int setup_diva_isapnp(struct IsdnCard *card)
                                }
                                card->para[1] = pnp_port_start(pnp_d, 0);
                                card->para[0] = pnp_irq(pnp_d, 0);
-                               if (!card->para[0] || !card->para[1]) {
+                               if (card->para[0] == -1 || !card->para[1]) {
                                        printk(KERN_ERR "Diva PnP:some resources are missing %ld/%lx\n",
                                               card->para[0], card->para[1]);
                                        pnp_disable_dev(pnp_d);