x86/kvm/mmu: get rid of redundant kvm_mmu_setup()
authorPaolo Bonzini <pbonzini@redhat.com>
Mon, 8 Oct 2018 19:28:09 +0000 (21:28 +0200)
committerPaolo Bonzini <pbonzini@redhat.com>
Tue, 16 Oct 2018 22:30:04 +0000 (00:30 +0200)
Just inline the contents into the sole caller, kvm_init_mmu is now
public.

Suggested-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Sean Christopherson <sean.j.christopherson@intel.com>
arch/x86/include/asm/kvm_host.h
arch/x86/kvm/mmu.c
arch/x86/kvm/x86.c

index 7448d0b744c9cf094b54f3f591aaeda45621c690..992bc1058170ec389e34d4cd025b0fd03c0e59d2 100644 (file)
@@ -1188,7 +1188,6 @@ void kvm_mmu_module_exit(void);
 
 void kvm_mmu_destroy(struct kvm_vcpu *vcpu);
 int kvm_mmu_create(struct kvm_vcpu *vcpu);
-void kvm_mmu_setup(struct kvm_vcpu *vcpu);
 void kvm_mmu_init_vm(struct kvm *kvm);
 void kvm_mmu_uninit_vm(struct kvm *kvm);
 void kvm_mmu_set_mask_ptes(u64 user_mask, u64 accessed_mask,
index bf9e3145ff0b3f53a1431cff8ee0e6b9b2d15261..dd147fa5b3f44aac38ed93571258d69c4c7e8883 100644 (file)
@@ -5442,18 +5442,6 @@ int kvm_mmu_create(struct kvm_vcpu *vcpu)
        return alloc_mmu_pages(vcpu);
 }
 
-void kvm_mmu_setup(struct kvm_vcpu *vcpu)
-{
-       MMU_WARN_ON(VALID_PAGE(vcpu->arch.mmu->root_hpa));
-
-       /*
-        * kvm_mmu_setup() is called only on vCPU initialization.  
-        * Therefore, no need to reset mmu roots as they are not yet
-        * initialized.
-        */
-       kvm_init_mmu(vcpu, false);
-}
-
 static void kvm_mmu_invalidate_zap_pages_in_memslot(struct kvm *kvm,
                        struct kvm_memory_slot *slot,
                        struct kvm_page_track_notifier_node *node)
index a87e879373fe94afbde03f4c7225ee85f2fcb2fe..2750270b7a39559e14cac2b0d8ae478f99227cf7 100644 (file)
@@ -8484,7 +8484,7 @@ int kvm_arch_vcpu_setup(struct kvm_vcpu *vcpu)
        kvm_vcpu_mtrr_init(vcpu);
        vcpu_load(vcpu);
        kvm_vcpu_reset(vcpu, false);
-       kvm_mmu_setup(vcpu);
+       kvm_init_mmu(vcpu, false);
        vcpu_put(vcpu);
        return 0;
 }