net/sched: actions: remove unused 'order'
authorDavide Caratti <dcaratti@redhat.com>
Tue, 12 Nov 2019 14:33:11 +0000 (15:33 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 12 Nov 2019 20:11:22 +0000 (12:11 -0800)
after commit 4097e9d250fb ("net: sched: don't use tc_action->order during
action dump"), 'act->order' is initialized but then it's no more read, so
we can just remove this member of struct tc_action.

CC: Ivan Vecera <ivecera@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Reviewed-by: Ivan Vecera <ivecera@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/act_api.h
net/sched/act_api.c

index 0495bdc034d20d5c38ee3832ca3d2e637fdc5f38..71347a90a9d1d769fc801412b0a21c1452fd56fe 100644 (file)
@@ -23,7 +23,6 @@ struct tc_action_ops;
 struct tc_action {
        const struct tc_action_ops      *ops;
        __u32                           type; /* for backward compat(TCA_OLD_COMPAT) */
-       __u32                           order;
        struct tcf_idrinfo              *idrinfo;
 
        u32                             tcfa_index;
index bda1ba25c59e973709998b7e6279eee30589cbb8..7fc1e2c1b65634afd4f3f44075a98c0e82e6ee7e 100644 (file)
@@ -1003,7 +1003,6 @@ int tcf_action_init(struct net *net, struct tcf_proto *tp, struct nlattr *nla,
                        err = PTR_ERR(act);
                        goto err;
                }
-               act->order = i;
                sz += tcf_action_fill_size(act);
                /* Start from index 0 */
                actions[i - 1] = act;