b43: fix two warnings
authorJohannes Berg <johannes@sipsolutions.net>
Wed, 2 Dec 2009 10:20:36 +0000 (11:20 +0100)
committerJohn W. Linville <linville@tuxdriver.com>
Fri, 4 Dec 2009 19:16:25 +0000 (14:16 -0500)
My gcc appears to be able to see past the function
boundary and notices that the variable 'behaviour'
could be used uninitialised:

drivers/net/wireless/b43/leds.c: In function ‘b43_leds_register’:
drivers/net/wireless/b43/leds.c:339: warning: ‘behaviour’ may be used uninitialized in this function
drivers/net/wireless/b43/leds.c: In function ‘b43_leds_init’:
drivers/net/wireless/b43/leds.c:262: warning: ‘behaviour’ may be used uninitialized in this function

because b43_led_get_sprominfo() didn't initialise
it in all cases.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/b43/leds.c

index 1e8dba4880047352f445807b80b24865b90c9b35..c587115dd2b9685175e7449ebb0cd118d870488a 100644 (file)
@@ -246,6 +246,7 @@ static void b43_led_get_sprominfo(struct b43_wldev *dev,
                        *behaviour = B43_LED_OFF;
                        break;
                default:
+                       *behaviour = B43_LED_OFF;
                        B43_WARN_ON(1);
                        return;
                }