libperf: Warn when exceeding MAX_NR_CPUS in cpumap
authorKyle Meyer <meyerk@hpe.com>
Tue, 27 Aug 2019 21:43:52 +0000 (16:43 -0500)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 29 Aug 2019 20:38:32 +0000 (17:38 -0300)
Display a warning when attempting to profile more than MAX_NR_CPU CPUs.
This patch should not change any behavior.

Signed-off-by: Kyle Meyer <kyle.meyer@hpe.com>
Reviewed-by: Jiri Olsa <jolsa@redhat.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Russ Anderson <russ.anderson@hpe.com>
Link: http://lore.kernel.org/lkml/20190827214352.94272-8-meyerk@stormcage.eag.rdlabs.hpecorp.net
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/lib/cpumap.c

index 2834753576b2658b47c83c024f6e5cbffb4743bb..1f0e6f334237ac3243548f3504baf45b22788a3d 100644 (file)
@@ -100,6 +100,9 @@ struct perf_cpu_map *perf_cpu_map__read(FILE *file)
                if (prev >= 0) {
                        int new_max = nr_cpus + cpu - prev - 1;
 
+                       WARN_ONCE(new_max >= MAX_NR_CPUS, "Perf can support %d CPUs. "
+                                                         "Consider raising MAX_NR_CPUS\n", MAX_NR_CPUS);
+
                        if (new_max >= max_entries) {
                                max_entries = new_max + MAX_NR_CPUS / 2;
                                tmp = realloc(tmp_cpus, max_entries * sizeof(int));
@@ -192,6 +195,9 @@ struct perf_cpu_map *perf_cpu_map__new(const char *cpu_list)
                        end_cpu = start_cpu;
                }
 
+               WARN_ONCE(end_cpu >= MAX_NR_CPUS, "Perf can support %d CPUs. "
+                                                 "Consider raising MAX_NR_CPUS\n", MAX_NR_CPUS);
+
                for (; start_cpu <= end_cpu; start_cpu++) {
                        /* check for duplicates */
                        for (i = 0; i < nr_cpus; i++)