staging: rtl8723bs: remove unused code
authorColin Ian King <colin.king@canonical.com>
Sat, 16 Mar 2019 22:26:57 +0000 (22:26 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 18 Mar 2019 06:06:16 +0000 (07:06 +0100)
There are two final hunks of code that are only built
if SDIO_DYNAMIC_ALLOC_MEM is defined however this is never
defined and if it was the code would lead to dereferencing
an uninitialized pointer oldmem.  It appears that a previous
commit 1babeb0c3e59 ("Staging: rtl8723bs: Remove dead code")
removed some of the dead code but not all of it. Clean this
up by removing the final hunks.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/hal/sdio_ops.c

index 3fee344845776dc26da55da054064a6ceb1d0223..92191e9789bb0681c620716a8f20a5b7bb17d231 100644 (file)
@@ -428,9 +428,6 @@ static u32 sdio_read_port(
        PSDIO_DATA psdio;
        struct hal_com_data *hal;
        u32 oldcnt;
-#ifdef SDIO_DYNAMIC_ALLOC_MEM
-       u8 *oldmem;
-#endif
        s32 err;
 
 
@@ -447,13 +444,6 @@ static u32 sdio_read_port(
 
        err = _sd_read(intfhdl, addr, cnt, mem);
 
-#ifdef SDIO_DYNAMIC_ALLOC_MEM
-       if ((oldcnt != cnt) && (oldmem)) {
-               memcpy(oldmem, mem, oldcnt);
-               kfree(mem);
-       }
-#endif
-
        if (err)
                return _FAIL;
        return _SUCCESS;