lantiq: dts: Move the &usb_vbus nodes out of &gpio
authorLuca Olivetti <luca@ventoso.org>
Mon, 6 Jul 2020 18:24:02 +0000 (20:24 +0200)
committerAdrian Schmutzler <freifunk@adrianschmutzler.de>
Fri, 10 Jul 2020 11:55:21 +0000 (13:55 +0200)
Move the USB VBUS regulator nodes out of the GPIO controller node. This
fixes a problem where the "regulator-fixed" driver wasn't probed for
these regulators because the GPIO driver doesn't scan the child-nodes
and based on the dt-bindings documentation it's not supposed to.

This fixed the following error reported by Luca Olivetti:
  ...
  dwc2 1e101000.usb: DWC OTG Controller
  dwc2 1e101000.usb: new USB bus registered, assigned bus number 1
  dwc2 1e101000.usb: irq 62, io mem 0x1e101000
  dwc2 1e101000.usb: startup error -517
  dwc2 1e101000.usb: USB bus 1 deregistered
  dwc2 1e101000.usb: dwc2_hcd_init() FAILED, returning -517

Fixes: FS#1634
Cc: Luca Olivetti <luca@ventoso.org>
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
[backported from 982468de35d499f85470b7b547d2b27cea53bae0]
Signed-off-by: Luca Olivetti <luca@ventoso.org>
target/linux/lantiq/files-4.14/arch/mips/boot/dts/ARV7510PW22.dts
target/linux/lantiq/files-4.14/arch/mips/boot/dts/ARV7518PW.dts
target/linux/lantiq/files-4.14/arch/mips/boot/dts/ARV752DPW.dts
target/linux/lantiq/files-4.14/arch/mips/boot/dts/P2601HNFX.dts

index 92d01b4dcc3507a06bb3576bb41c2dcbab717363..404502426fe4b400f88f29c97bdacbe9a697ca8d 100644 (file)
                        gpios = <&gpio 20 GPIO_ACTIVE_LOW>;
                };
        };
+
+       usb_vbus: regulator-usb-vbus {
+               compatible = "regulator-fixed";
+
+               regulator-name = "USB_VBUS";
+
+               regulator-min-microvolt = <5000000>;
+               regulator-max-microvolt = <5000000>;
+
+               gpio = <&gpio 8 GPIO_ACTIVE_HIGH>;
+               enable-active-high;
+       };
 };
 
 &gpio {
                        lantiq,output = <0>;
                };
        };
-
-       usb_vbus: regulator-usb-vbus {
-               compatible = "regulator-fixed";
-
-               regulator-name = "USB_VBUS";
-
-               regulator-min-microvolt = <5000000>;
-               regulator-max-microvolt = <5000000>;
-
-               gpio = <&gpio 8 GPIO_ACTIVE_HIGH>;
-               enable-active-high;
-       };
 };
 
 &gsw {
index 72f3a686b5fdb0c4424e538d6f482f7613175823..62b67d40eb2f23cc7cdda5fd524dac927aeae698 100644 (file)
                        gpios = <&gpiomm 6 GPIO_ACTIVE_LOW>;
                };
        };
+
+       usb_vbus: regulator-usb-vbus {
+               compatible = "regulator-fixed";
+
+               regulator-name = "USB_VBUS";
+
+               regulator-min-microvolt = <5000000>;
+               regulator-max-microvolt = <5000000>;
+
+               gpio = <&gpio 14 GPIO_ACTIVE_HIGH>;
+               enable-active-high;
+       };
 };
 
 &gpio {
                        lantiq,open-drain = <1>;
                };
        };
-
-       usb_vbus: regulator-usb-vbus {
-               compatible = "regulator-fixed";
-
-               regulator-name = "USB_VBUS";
-
-               regulator-min-microvolt = <5000000>;
-               regulator-max-microvolt = <5000000>;
-
-               gpio = <&gpio 14 GPIO_ACTIVE_HIGH>;
-               enable-active-high;
-       };
 };
 
 &gpiomm {
index 5f877723f6d0097ff44d449a2c8c0d5c8310035a..214795025ca333e610d14f01a1449c4ffc2dad10 100644 (file)
                        gpios = <&gpiomm 9 GPIO_ACTIVE_LOW>;
                };
        };
+
+       usb_vbus: regulator-usb-vbus {
+               compatible = "regulator-fixed";
+
+               regulator-name = "USB_VBUS";
+
+               regulator-min-microvolt = <5000000>;
+               regulator-max-microvolt = <5000000>;
+
+               gpio = <&gpiomm 0 GPIO_ACTIVE_HIGH>;
+               enable-active-high;
+       };
 };
 
 &gpio {
                        lantiq,open-drain = <1>;
                };
        };
-
-       usb_vbus: regulator-usb-vbus {
-               compatible = "regulator-fixed";
-
-               regulator-name = "USB_VBUS";
-
-               regulator-min-microvolt = <5000000>;
-               regulator-max-microvolt = <5000000>;
-
-               gpio = <&gpiomm 0 GPIO_ACTIVE_HIGH>;
-               enable-active-high;
-       };
 };
 
 &gpiomm {
index 5606eb6e8ba0a379aea1074bcdbc978427c34d39..bb872ad26acbabb1692496810393aeee7944442d 100644 (file)
                        gpios = <&gpio 50 GPIO_ACTIVE_HIGH>;
                };
        };
+
+       usb_vbus: regulator-usb-vbus {
+               compatible = "regulator-fixed";
+
+               regulator-name = "USB_VBUS";
+
+               regulator-min-microvolt = <5000000>;
+               regulator-max-microvolt = <5000000>;
+
+               gpio = <&gpio 9 GPIO_ACTIVE_HIGH>;
+               enable-active-high;
+       };
 };
 
 &gpio {
                        lantiq,function = "mdio";
                };
        };
-
-       usb_vbus: regulator-usb-vbus {
-               compatible = "regulator-fixed";
-
-               regulator-name = "USB_VBUS";
-
-               regulator-min-microvolt = <5000000>;
-               regulator-max-microvolt = <5000000>;
-
-               gpio = <&gpio 9 GPIO_ACTIVE_HIGH>;
-               enable-active-high;
-       };
 };
 
 &gsw {