[media] media: lirc_dev: clarify error handling

If an error is generated, it is more logical to error out ASAP.

Signed-off-by: David Härdeman <david@hardeman.nu>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>

diff --git a/drivers/media/rc/lirc_dev.c b/drivers/media/rc/lirc_dev.c
index 9080e39ea391e9da698abcfdfb5261de476ab271..5e3c4779d8660338b37879e8080962a795e3b25b 100644 (file)
--- a/drivers/media/rc/lirc_dev.c
+++ b/drivers/media/rc/lirc_dev.c
@@ -286,7 +286,7 @@ EXPORT_SYMBOL(lirc_unregister_driver);
 int lirc_dev_fop_open(struct inode *inode, struct file *file)
 {
        struct irctl *ir;
-       int retval = 0;
+       int retval;
 
        if (iminor(inode) >= MAX_IRCTL_DEVICES) {
                pr_err("open result for %d is -ENODEV\n", iminor(inode));
@@ -327,9 +327,11 @@ int lirc_dev_fop_open(struct inode *inode, struct file *file)
 
        ir->open++;
 
-error:
        nonseekable_open(inode, file);
 
+       return 0;
+
+error:
        return retval;
 }
 EXPORT_SYMBOL(lirc_dev_fop_open);