bridge: add address and vlan to fdb warning messages
authorRoopa Prabhu <roopa@cumulusnetworks.com>
Tue, 11 Oct 2016 23:12:56 +0000 (16:12 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 13 Oct 2016 14:49:54 +0000 (10:49 -0400)
This patch adds vlan and address to warning messages printed
in the bridge fdb code for debuggability.

Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/bridge/br_fdb.c

index 6b43c8c88f19b37bd4063347719f698beb2c377a..e4a4176171c91fa364e914e2aeb9d357209a1f93 100644 (file)
@@ -535,9 +535,8 @@ static int fdb_insert(struct net_bridge *br, struct net_bridge_port *source,
                 */
                if (fdb->is_local)
                        return 0;
-               br_warn(br, "adding interface %s with same address "
-                      "as a received packet\n",
-                      source ? source->dev->name : br->dev->name);
+               br_warn(br, "adding interface %s with same address as a received packet (addr:%pM, vlan:%u)\n",
+                      source ? source->dev->name : br->dev->name, addr, vid);
                fdb_delete(br, fdb);
        }
 
@@ -583,9 +582,8 @@ void br_fdb_update(struct net_bridge *br, struct net_bridge_port *source,
                /* attempt to update an entry for a local interface */
                if (unlikely(fdb->is_local)) {
                        if (net_ratelimit())
-                               br_warn(br, "received packet on %s with "
-                                       "own address as source address\n",
-                                       source->dev->name);
+                               br_warn(br, "received packet on %s with own address as source address (addr:%pM, vlan:%u)\n",
+                                       source->dev->name, addr, vid);
                } else {
                        /* fastpath: update of existing entry */
                        if (unlikely(source != fdb->dst)) {