fs/aio.c: eliminate redundant loads in put_aio_ring_file
authorRasmus Villemoes <linux@rasmusvillemoes.dk>
Wed, 14 Sep 2016 22:25:03 +0000 (00:25 +0200)
committerAl Viro <viro@zeniv.linux.org.uk>
Wed, 28 Sep 2016 01:45:46 +0000 (21:45 -0400)
Using a local variable we can prevent gcc from reloading
aio_ring_file->f_inode->i_mapping twice, eliminating 2x2 dependent
loads.

Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/aio.c

index 4fe81d1c60f962b53392a6b4b0d047f129509c87..1157e13a36d681ecba8e926bb9e91943cfeb6723 100644 (file)
--- a/fs/aio.c
+++ b/fs/aio.c
@@ -274,14 +274,17 @@ __initcall(aio_setup);
 static void put_aio_ring_file(struct kioctx *ctx)
 {
        struct file *aio_ring_file = ctx->aio_ring_file;
+       struct address_space *i_mapping;
+
        if (aio_ring_file) {
                truncate_setsize(aio_ring_file->f_inode, 0);
 
                /* Prevent further access to the kioctx from migratepages */
-               spin_lock(&aio_ring_file->f_inode->i_mapping->private_lock);
-               aio_ring_file->f_inode->i_mapping->private_data = NULL;
+               i_mapping = aio_ring_file->f_inode->i_mapping;
+               spin_lock(&i_mapping->private_lock);
+               i_mapping->private_data = NULL;
                ctx->aio_ring_file = NULL;
-               spin_unlock(&aio_ring_file->f_inode->i_mapping->private_lock);
+               spin_unlock(&i_mapping->private_lock);
 
                fput(aio_ring_file);
        }