pcmcia: remove KERN_INFO level from debug message
authorColin Ian King <colin.king@canonical.com>
Fri, 17 Jul 2015 10:02:34 +0000 (11:02 +0100)
committerDominik Brodowski <linux@dominikbrodowski.net>
Mon, 1 Oct 2018 10:15:16 +0000 (12:15 +0200)
The KERN_INFO level is being appended to the "%s:" string in the DEBUGP
macro, so it isn't actually doing what was originally intended and instead
inserts it in the wrong place.  Remove it so it is at least we're using
the DEBUGP macro consistently throughout the driver and we're not going
to lose any functionality in message level with change anyhow.

Caught by smatch static analysis:

  drivers/char/pcmcia/cm4040_cs.c:509 cm4040_reader_release()
     warn: KERN_* level not at start of string

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Cc: Harald Welte <laforge@gnumonks.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
drivers/char/pcmcia/cm4040_cs.c

index f80965407d3ccc74d132cb8817aa886661581067..d5e43606339c3583d751bae8c03ccc85f7d9bf82 100644 (file)
@@ -505,7 +505,7 @@ static void cm4040_reader_release(struct pcmcia_device *link)
 
        DEBUGP(3, dev, "-> cm4040_reader_release\n");
        while (link->open) {
-               DEBUGP(3, dev, KERN_INFO MODULE_NAME ": delaying release "
+               DEBUGP(3, dev, MODULE_NAME ": delaying release "
                       "until process has terminated\n");
                wait_event(dev->devq, (link->open == 0));
        }