drm/amdgpu: remove redundant memset
authorPhilip Yang <Philip.Yang@amd.com>
Wed, 29 Aug 2018 14:53:23 +0000 (10:53 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 29 Aug 2018 17:36:06 +0000 (12:36 -0500)
kvmalloc_array uses __GFP_ZERO flag ensures that the returned address
is zeroed already, memset it to zero again afterwards is unnecessary,
and in this case buggy because we only clear the first entry.

Signed-off-by: Philip Yang <Philip.Yang@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c

index 521ddb358ec17555e4f3f3fe27d951872928105c..f50697df97994246ec51859de5179a41329ae93f 100644 (file)
@@ -541,7 +541,6 @@ static int amdgpu_vm_alloc_levels(struct amdgpu_device *adev,
                                                   GFP_KERNEL | __GFP_ZERO);
                if (!parent->entries)
                        return -ENOMEM;
-               memset(parent->entries, 0 , sizeof(struct amdgpu_vm_pt));
        }
 
        from = saddr >> shift;