scsi: qla2xxx: Remove the fcport test from qla_nvme_abort_work()

Testing whether a pointer is not NULL after it has been dereferenced is not
useful. Hence remove the if (fcport) test. This was detected by Coverity.

Cc: Himanshu Madhani <hmadhani@marvell.com>
Cc: Giridhar Malavali <gmalavali@marvell.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Acked-by: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c
index 8dd6220857d40018810e89b0fc4dfd640312a02a..5d9191278f41e50bc358b35d456cee8f0926a12f 100644 (file)
--- a/drivers/scsi/qla2xxx/qla_nvme.c
+++ b/drivers/scsi/qla2xxx/qla_nvme.c
@@ -186,10 +186,9 @@ static void qla_nvme_abort_work(struct work_struct *work)
        struct qla_hw_data *ha = fcport->vha->hw;
        int rval;
 
-       if (fcport)
-               ql_dbg(ql_dbg_io, fcport->vha, 0xffff,
-                   "%s called for sp=%p, hndl=%x on fcport=%p deleted=%d\n",
-                   __func__, sp, sp->handle, fcport, fcport->deleted);
+       ql_dbg(ql_dbg_io, fcport->vha, 0xffff,
+              "%s called for sp=%p, hndl=%x on fcport=%p deleted=%d\n",
+              __func__, sp, sp->handle, fcport, fcport->deleted);
 
        if (!ha->flags.fw_started && (fcport && fcport->deleted))
                return;