powerpc/pci: Drop unnecessary null test
authorJulia Lawall <julia@diku.dk>
Tue, 3 Aug 2010 11:35:17 +0000 (11:35 +0000)
committerBenjamin Herrenschmidt <benh@kernel.crashing.org>
Tue, 24 Aug 2010 05:26:28 +0000 (15:26 +1000)
list_for_each_entry binds its first argument to a non-null value, and thus
any null test on the value of that argument is superfluous.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
iterator I;
expression x,E,E1,E2;
statement S,S1,S2;
@@

I(x,...) { <...
- if (x != NULL || ...)
  S
  ...> }
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
arch/powerpc/kernel/pci_of_scan.c

index 6ddb795f83e8e9ccd62e713d997599baee77122a..62dd363a976295f056dd65d1a444cb55b0ec8e59 100644 (file)
@@ -336,8 +336,7 @@ static void __devinit __of_scan_bus(struct device_node *node,
                if (dev->hdr_type == PCI_HEADER_TYPE_BRIDGE ||
                    dev->hdr_type == PCI_HEADER_TYPE_CARDBUS) {
                        struct device_node *child = pci_device_to_OF_node(dev);
-                       if (dev)
-                               of_scan_pci_bridge(child, dev);
+                       of_scan_pci_bridge(child, dev);
                }
        }
 }