platform/chrome: cros_ec: Do not attempt to register a non-positive IRQ number
authorGwendal Grignou <gwendal@chromium.org>
Tue, 19 Nov 2019 12:45:46 +0000 (13:45 +0100)
committerEnric Balletbo i Serra <enric.balletbo@collabora.com>
Thu, 21 Nov 2019 10:23:15 +0000 (11:23 +0100)
Add a layer of sanity checking to cros_ec_register against attempting to
register IRQ values that are not strictly greater than 0.

Signed-off-by: Enrico Granata <egranata@chromium.org>
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Acked-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
drivers/platform/chrome/cros_ec.c

index 925f84dbf621845277e5d3218c7d1ca461d5f782..d3dfa27171e6d583a3c12235c2f15448a5faec20 100644 (file)
@@ -149,7 +149,7 @@ int cros_ec_register(struct cros_ec_device *ec_dev)
                return err;
        }
 
-       if (ec_dev->irq) {
+       if (ec_dev->irq > 0) {
                err = devm_request_threaded_irq(dev, ec_dev->irq,
                                                ec_irq_handler,
                                                ec_irq_thread,