lantiq: unify Fritz!Box LED mappings
authorDavid Bauer <mail@david-bauer.net>
Sun, 11 Aug 2019 21:37:24 +0000 (23:37 +0200)
committerDavid Bauer <mail@david-bauer.net>
Thu, 15 Aug 2019 12:53:04 +0000 (14:53 +0200)
This commit unifies the LED mapping of the AVM Fritz!Box routers, which
have a combined Power/DSL LED.

With the stock firmware, the Power LED has the following
characteristics:

 - Blink when DSL sync is being established
 - Solid when DSL sync is present

We can't completely resemble this behavior in OpenWrt. Currently, the
Power LED is completely off, when DSL sync is missing. This is not
really helpful, as a user might have the impression, that he bricked his
device.

Instead, map the Info-LED to the state of the DSL connection.
There is no consistent behavior for the Info-LED in the stock
firmware, as the user can set it's function by himself. The DSL
connection state is one possible option for the Info LED there.

Also use the red Power LED to indicate a running upgrade, in case the
board has a two-color Power LED.

Signed-off-by: David Bauer <mail@david-bauer.net>
(cherry picked from commit 3032bf7f89e8ad5b69ab2f031287f475e5d2b829)

target/linux/lantiq/files-4.14/arch/mips/boot/dts/FRITZ3370-REV2.dtsi
target/linux/lantiq/files-4.14/arch/mips/boot/dts/FRITZ7312.dts
target/linux/lantiq/files-4.14/arch/mips/boot/dts/FRITZ7320.dts
target/linux/lantiq/files-4.14/arch/mips/boot/dts/FRITZ736X.dtsi

index 9a0359d1ccdbbe5e0374e41ed1ba9fd1150543de..e86e544945a8189a151d8402f26125c07b24f454 100644 (file)
@@ -15,7 +15,7 @@
                led-boot = &power_green;
                led-failsafe = &power_red;
                led-running = &power_green;
-               led-upgrade = &power_green;
+               led-upgrade = &power_red;
 
                led-dsl = &dsl;
                led-internet = &info_green;
index 796b941ede689fabdf935fdce21bcb914e8b5f1b..29da0fb8e51ee290d22dd1e8dc9b2507b716c9d1 100644 (file)
@@ -18,8 +18,7 @@
                led-running = &power;
                led-upgrade = &power;
 
-               led-internet = &info_green;
-               led-dsl = &power;
+               led-dsl = &info_green;
                led-wifi = &wlan;
        };
 
index a4afca11fadef56b675d85a7be950dd57af0aebd..89fc3858b7bb31c200923cd00c707688f18abb84 100644 (file)
@@ -18,8 +18,7 @@
                led-running = &power;
                led-upgrade = &power;
 
-               led-internet = &info_green;
-               led-dsl = &power;
+               led-dsl = &info_green;
                led-wifi = &wlan;
        };
 
index 9c1d2db8fae1049a84d5d315d59793b134763540..8ed23deb44ca464ee016a30b3e2572fa539fc7b4 100644 (file)
@@ -17,7 +17,8 @@
                led-boot = &power_green;
                led-failsafe = &power_red;
                led-running = &power_green;
-               led-upgrade = &power_green;
+               led-upgrade = &power_red;
+
                led-dsl = &info_green;
                led-wifi = &wifi;
        };