staging: ks7010: change name and type for device_open_status field
authorSergio Paracuellos <sergio.paracuellos@gmail.com>
Mon, 23 Apr 2018 13:44:48 +0000 (15:44 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 25 Apr 2018 13:47:23 +0000 (15:47 +0200)
This commit changes type for device_open_status field of ks_wlan_private
structure from int to bool. This variable is only be set to 1
on ks_wlan_net_start and set to 0 on ks_wlan_net_stop. For this
purpose it is not necessary at all to use an integer because a bool
is enough. This also renames field name from device_open_status to
is_device_open.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/ks7010/ks_hostif.c
drivers/staging/ks7010/ks_wlan.h
drivers/staging/ks7010/ks_wlan_net.c

index d11b0a2259e239a336a842657f7c615eb680510f..3b10f9ac0fa000910589b5013f19b2cc12724015 100644 (file)
@@ -1562,7 +1562,7 @@ void hostif_mic_failure_request(struct ks_wlan_private *priv,
 static void devio_rec_ind(struct ks_wlan_private *priv, unsigned char *p,
                          unsigned int size)
 {
-       if (priv->device_open_status) {
+       if (priv->is_device_open) {
                spin_lock(&priv->dev_read_lock);        /* request spin lock */
                priv->dev_data[atomic_read(&priv->rec_count)] = p;
                priv->dev_size[atomic_read(&priv->rec_count)] = size;
index 615c42e2cffb107ba960b5b3eda8448609022981..52de44866d538d3f62c1652e00f0a1615590c673 100644 (file)
@@ -424,7 +424,7 @@ struct ks_wlan_private {
        unsigned int need_commit;       /* for ioctl */
 
        /* DeviceIoControl */
-       bool device_open_status;
+       bool is_device_open;
        atomic_t event_count;
        atomic_t rec_count;
        int dev_count;
index 05f8216e502bc180725c4b92033a2c075b4ed0f5..76ed4ed9d1670037f7e0a71b3ddaeec68449cedb 100644 (file)
@@ -2816,9 +2816,8 @@ int ks_wlan_net_start(struct net_device *dev)
 
        priv = netdev_priv(dev);
        priv->mac_address_valid = false;
-       priv->device_open_status = true;
+       priv->is_device_open = true;
        priv->need_commit = 0;
-
        /* phy information update timer */
        atomic_set(&update_phyinfo, 0);
        timer_setup(&update_phyinfo_timer, ks_wlan_update_phyinfo_timeout, 0);
@@ -2848,7 +2847,7 @@ int ks_wlan_net_stop(struct net_device *dev)
 {
        struct ks_wlan_private *priv = netdev_priv(dev);
 
-       priv->device_open_status = false;
+       priv->is_device_open = false;
        del_timer_sync(&update_phyinfo_timer);
 
        if (netif_running(dev))