greybus: vibrator: fix tear-down race

Do not release the minor number until after the device has been
deregistered.

Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>

diff --git a/drivers/staging/greybus/vibrator.c b/drivers/staging/greybus/vibrator.c
index 96d649acf122a8de81f91a7467b30b4b2a81166d..fd40cda565e48c73abbcb0a47e1c224285012237 100644 (file)
--- a/drivers/staging/greybus/vibrator.c
+++ b/drivers/staging/greybus/vibrator.c
@@ -148,8 +148,8 @@ static void gb_vibrator_connection_exit(struct gb_connection *connection)
 #if LINUX_VERSION_CODE <= KERNEL_VERSION(3,11,0)
        sysfs_remove_group(&vib->dev->kobj, vibrator_groups[0]);
 #endif
-       ida_simple_remove(&minors, vib->minor);
        device_unregister(vib->dev);
+       ida_simple_remove(&minors, vib->minor);
        kfree(vib);
 }