Move console.c to pl011 specific driver location
authorDan Handley <dan.handley@arm.com>
Mon, 14 Apr 2014 16:03:01 +0000 (17:03 +0100)
committerDan Handley <dan.handley@arm.com>
Mon, 14 Apr 2014 16:03:01 +0000 (17:03 +0100)
Rename drivers/console/console.c to
drivers/arm/peripherals/pl011/pl011_console.c. This makes it clear
that this is a pl011 specific console implementation.

Fixes ARM-software/tf-issues#129

Change-Id: Ie2f8109602134c5b86993e32452c70734c45a3ed

drivers/arm/peripherals/pl011/pl011_console.c [new file with mode: 0644]
drivers/console/console.c [deleted file]
plat/fvp/platform.mk

diff --git a/drivers/arm/peripherals/pl011/pl011_console.c b/drivers/arm/peripherals/pl011/pl011_console.c
new file mode 100644 (file)
index 0000000..1a684ff
--- /dev/null
@@ -0,0 +1,89 @@
+/*
+ * Copyright (c) 2013-2014, ARM Limited and Contributors. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ *
+ * Redistributions of source code must retain the above copyright notice, this
+ * list of conditions and the following disclaimer.
+ *
+ * Redistributions in binary form must reproduce the above copyright notice,
+ * this list of conditions and the following disclaimer in the documentation
+ * and/or other materials provided with the distribution.
+ *
+ * Neither the name of ARM nor the names of its contributors may be used
+ * to endorse or promote products derived from this software without specific
+ * prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
+ * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include <console.h>
+#include <platform.h>
+#include <pl011.h>
+#include <assert.h>
+
+static unsigned long uart_base;
+
+void console_init(unsigned long base_addr)
+{
+       /* TODO: assert() internally calls printf() and will result in
+        * an infinite loop. This needs to be fixed with some kind of
+        * exception  mechanism or early panic support. This also applies
+        * to the other assert() calls below.
+        */
+       assert(base_addr);
+
+       /* Initialise internal base address variable */
+       uart_base = base_addr;
+
+       /* Baud Rate */
+#if defined(PL011_INTEGER) && defined(PL011_FRACTIONAL)
+       pl011_write_ibrd(uart_base, PL011_INTEGER);
+       pl011_write_fbrd(uart_base, PL011_FRACTIONAL);
+#else
+       pl011_setbaudrate(uart_base, PL011_BAUDRATE);
+#endif
+
+       pl011_write_lcr_h(uart_base, PL011_LINE_CONTROL);
+
+       /* Clear any pending errors */
+       pl011_write_ecr(uart_base, 0);
+
+       /* Enable tx, rx, and uart overall */
+       pl011_write_cr(uart_base, PL011_UARTCR_RXE | PL011_UARTCR_TXE |
+                       PL011_UARTCR_UARTEN);
+
+}
+
+int console_putc(int c)
+{
+       assert(uart_base);
+
+       if (c == '\n')
+               console_putc('\r');
+
+       while ((pl011_read_fr(uart_base) & PL011_UARTFR_TXFF) == 1)
+               ;
+       pl011_write_dr(uart_base, c);
+       return c;
+}
+
+int console_getc(void)
+{
+       assert(uart_base);
+
+       while ((pl011_read_fr(uart_base) & PL011_UARTFR_RXFE) != 0)
+               ;
+       return pl011_read_dr(uart_base);
+}
diff --git a/drivers/console/console.c b/drivers/console/console.c
deleted file mode 100644 (file)
index 1a684ff..0000000
+++ /dev/null
@@ -1,89 +0,0 @@
-/*
- * Copyright (c) 2013-2014, ARM Limited and Contributors. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are met:
- *
- * Redistributions of source code must retain the above copyright notice, this
- * list of conditions and the following disclaimer.
- *
- * Redistributions in binary form must reproduce the above copyright notice,
- * this list of conditions and the following disclaimer in the documentation
- * and/or other materials provided with the distribution.
- *
- * Neither the name of ARM nor the names of its contributors may be used
- * to endorse or promote products derived from this software without specific
- * prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
- * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
- * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
- * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
- * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
- * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
- * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
- * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
- * POSSIBILITY OF SUCH DAMAGE.
- */
-
-#include <console.h>
-#include <platform.h>
-#include <pl011.h>
-#include <assert.h>
-
-static unsigned long uart_base;
-
-void console_init(unsigned long base_addr)
-{
-       /* TODO: assert() internally calls printf() and will result in
-        * an infinite loop. This needs to be fixed with some kind of
-        * exception  mechanism or early panic support. This also applies
-        * to the other assert() calls below.
-        */
-       assert(base_addr);
-
-       /* Initialise internal base address variable */
-       uart_base = base_addr;
-
-       /* Baud Rate */
-#if defined(PL011_INTEGER) && defined(PL011_FRACTIONAL)
-       pl011_write_ibrd(uart_base, PL011_INTEGER);
-       pl011_write_fbrd(uart_base, PL011_FRACTIONAL);
-#else
-       pl011_setbaudrate(uart_base, PL011_BAUDRATE);
-#endif
-
-       pl011_write_lcr_h(uart_base, PL011_LINE_CONTROL);
-
-       /* Clear any pending errors */
-       pl011_write_ecr(uart_base, 0);
-
-       /* Enable tx, rx, and uart overall */
-       pl011_write_cr(uart_base, PL011_UARTCR_RXE | PL011_UARTCR_TXE |
-                       PL011_UARTCR_UARTEN);
-
-}
-
-int console_putc(int c)
-{
-       assert(uart_base);
-
-       if (c == '\n')
-               console_putc('\r');
-
-       while ((pl011_read_fr(uart_base) & PL011_UARTFR_TXFF) == 1)
-               ;
-       pl011_write_dr(uart_base, c);
-       return c;
-}
-
-int console_getc(void)
-{
-       assert(uart_base);
-
-       while ((pl011_read_fr(uart_base) & PL011_UARTFR_RXFE) != 0)
-               ;
-       return pl011_read_dr(uart_base);
-}
index e8de0986e60ba7c6728ea8ff0b1e889a0ad8ba94..e3b484852df58699c056ffcb1bc064b2d67e0638 100644 (file)
@@ -34,7 +34,6 @@ PLAT_INCLUDES         :=      -Idrivers/arm/interconnect/cci-400      \
                                -Idrivers/power
 
 PLAT_BL1_C_VPATH       :=      drivers/arm/interconnect/cci-400        \
-                               drivers/console                         \
                                drivers/arm/peripherals/pl011           \
                                lib/arch/${ARCH}                        \
                                lib/semihosting                         \
@@ -44,7 +43,6 @@ PLAT_BL1_C_VPATH      :=      drivers/arm/interconnect/cci-400        \
 PLAT_BL1_S_VPATH       :=      lib/semihosting/${ARCH}
 
 PLAT_BL2_C_VPATH       :=      drivers/arm/interconnect/cci-400        \
-                               drivers/console                         \
                                drivers/arm/peripherals/pl011           \
                                lib/arch/${ARCH}                        \
                                lib/stdlib                              \
@@ -54,7 +52,6 @@ PLAT_BL2_C_VPATH      :=      drivers/arm/interconnect/cci-400        \
 PLAT_BL2_S_VPATH       :=      lib/semihosting/${ARCH}
 
 PLAT_BL31_C_VPATH      :=      drivers/arm/interconnect/cci-400        \
-                               drivers/console                         \
                                drivers/arm/peripherals/pl011           \
                                lib/arch/${ARCH}                        \
                                lib/semihosting                         \
@@ -66,7 +63,7 @@ PLAT_BL31_S_VPATH     :=      lib/semihosting/${ARCH}
 
 PLAT_BL_COMMON_SOURCES :=      semihosting_call.S                      \
                                mmio.c                                  \
-                               console.c                               \
+                               pl011_console.c                         \
                                pl011.c                                 \
                                semihosting.c                           \
                                sysreg_helpers.S                        \