cgroup: remove extra cgroup_migrate_finish() call
authorShakeel Butt <shakeelb@google.com>
Wed, 3 Apr 2019 23:03:54 +0000 (16:03 -0700)
committerTejun Heo <tj@kernel.org>
Thu, 4 Apr 2019 20:39:42 +0000 (13:39 -0700)
The callers of cgroup_migrate_prepare_dst() correctly call
cgroup_migrate_finish() for success and failure cases both. No need to
call it in cgroup_migrate_prepare_dst() in failure case.

Signed-off-by: Shakeel Butt <shakeelb@google.com>
Reviewed-by: Daniel Jordan <daniel.m.jordan@oracle.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
kernel/cgroup/cgroup.c

index 3f2b4bde0f9c3134659867f67a3ab485da0613e9..f219c195a9a5fc41c4c562de20e78a437271eede 100644 (file)
@@ -2602,7 +2602,7 @@ int cgroup_migrate_prepare_dst(struct cgroup_mgctx *mgctx)
 
                dst_cset = find_css_set(src_cset, src_cset->mg_dst_cgrp);
                if (!dst_cset)
-                       goto err;
+                       return -ENOMEM;
 
                WARN_ON_ONCE(src_cset->mg_dst_cset || dst_cset->mg_dst_cset);
 
@@ -2634,9 +2634,6 @@ int cgroup_migrate_prepare_dst(struct cgroup_mgctx *mgctx)
        }
 
        return 0;
-err:
-       cgroup_migrate_finish(mgctx);
-       return -ENOMEM;
 }
 
 /**