block: bvec_nr_vecs() returns value for wrong slab
authorGreg Edwards <gedwards@ddn.com>
Wed, 8 Aug 2018 19:27:53 +0000 (13:27 -0600)
committerJens Axboe <axboe@kernel.dk>
Thu, 9 Aug 2018 14:25:04 +0000 (08:25 -0600)
In commit ed996a52c868 ("block: simplify and cleanup bvec pool
handling"), the value of the slab index is incremented by one in
bvec_alloc() after the allocation is done to indicate an index value of
0 does not need to be later freed.

bvec_nr_vecs() was not updated accordingly, and thus returns the wrong
value.  Decrement idx before performing the lookup.

Fixes: ed996a52c868 ("block: simplify and cleanup bvec pool handling")
Signed-off-by: Greg Edwards <gedwards@ddn.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/bio.c

index b832151cd0bf42d06c8e46a27cc47105e41d66b3..04969b392c72d67cdf524e280790329068d41780 100644 (file)
@@ -158,7 +158,7 @@ out:
 
 unsigned int bvec_nr_vecs(unsigned short idx)
 {
-       return bvec_slabs[idx].nr_vecs;
+       return bvec_slabs[--idx].nr_vecs;
 }
 
 void bvec_free(mempool_t *pool, struct bio_vec *bv, unsigned int idx)