crypto: chtls - use 64-bit arithmetic instead of 32-bit
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Wed, 4 Jul 2018 16:37:20 +0000 (11:37 -0500)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 13 Jul 2018 10:26:49 +0000 (18:26 +0800)
Cast *val* to u64 in order to give the compiler complete
information about the proper arithmetic to use.

Notice that such variable is used in a context that expects an
expression of type u64 (64 bits, unsigned) and the following
expression is currently being evaluated using 32-bit arithmetic:

val << bit_pos

Addresses-Coverity-ID: 1467425 ("Unintentional integer overflow")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/chelsio/chtls/chtls_hw.c

index 55d50140f9e5a6c6fd07112f2ac650f2f31abdfb..490960755864468d33e33c4f59a9f558aa386f14 100644 (file)
@@ -97,7 +97,7 @@ static int chtls_set_tcb_field(struct sock *sk, u16 word, u64 mask, u64 val)
 int chtls_set_tcb_tflag(struct sock *sk, unsigned int bit_pos, int val)
 {
        return chtls_set_tcb_field(sk, 1, 1ULL << bit_pos,
-                                  val << bit_pos);
+                                  (u64)val << bit_pos);
 }
 
 static int chtls_set_tcb_keyid(struct sock *sk, int keyid)