tracing/kprobe: Remove unneeded extra strchr() from create_trace_kprobe()
authorSteven Rostedt (VMware) <rostedt@goodmis.org>
Fri, 24 Aug 2018 20:20:28 +0000 (16:20 -0400)
committerSteven Rostedt (VMware) <rostedt@goodmis.org>
Mon, 24 Sep 2018 08:44:52 +0000 (04:44 -0400)
By utilizing a temporary variable, we can avoid adding another call to
strchr(). Instead, save the first call to a temp variable, and then use that
variable as the reference to set the event variable.

Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
kernel/trace/trace_kprobe.c

index c30032367aab4a5c83a013d615830cda97a82f8a..508396edc56ad193a8d866e8dbcead0aeb661e60 100644 (file)
@@ -749,10 +749,13 @@ static int create_trace_kprobe(int argc, char **argv)
        }
 
        if (event) {
-               if (strchr(event, '/')) {
+               char *slash;
+
+               slash = strchr(event, '/');
+               if (slash) {
                        group = event;
-                       event = strchr(group, '/') + 1;
-                       event[-1] = '\0';
+                       event = slash + 1;
+                       slash[0] = '\0';
                        if (strlen(group) == 0) {
                                pr_info("Group name is not specified\n");
                                return -EINVAL;