ext4: remove extra IS_RDONLY() check
authorDave Hansen <haveblue@us.ibm.com>
Wed, 18 Jul 2007 12:33:51 +0000 (08:33 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Wed, 18 Jul 2007 12:33:51 +0000 (08:33 -0400)
ext4_change_inode_journal_flag() is only called from one location:
ext4_ioctl(EXT3_IOC_SETFLAGS).  That ioctl case already has a IS_RDONLY()
call in it so this one is superfluous.

Signed-off-by: Dave Hansen <haveblue@us.ibm.com>
Cc: <linux-ext4@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
fs/ext4/inode.c

index 125aca71468563a8f0966a17882cf6cb22f0e795..de26c25d6a181081cdf715ac2a44e78017ba0a16 100644 (file)
@@ -3275,7 +3275,7 @@ int ext4_change_inode_journal_flag(struct inode *inode, int val)
         */
 
        journal = EXT4_JOURNAL(inode);
-       if (is_journal_aborted(journal) || IS_RDONLY(inode))
+       if (is_journal_aborted(journal))
                return -EROFS;
 
        jbd2_journal_lock_updates(journal);