efi_loader: remove superfluous check in efi_setup_loaded_image()
authorHeinrich Schuchardt <xypron.glpk@gmx.de>
Tue, 19 Mar 2019 17:58:58 +0000 (18:58 +0100)
committerHeinrich Schuchardt <xypron.glpk@gmx.de>
Wed, 20 Mar 2019 17:16:53 +0000 (18:16 +0100)
It does not make any sense to check if a pointer is NULL if we have
dereferenced it before.

Reported-by: Coverity (CID 185827)
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
lib/efi_loader/efi_boottime.c

index bd8b8a17ae719d80be4bae933aeb18788b9bf06a..4fc550d9f376fa657c0805d6c9977bebd583f512 100644 (file)
@@ -1581,10 +1581,8 @@ efi_status_t efi_setup_loaded_image(struct efi_device_path *device_path,
                goto failure;
 #endif
 
-       if (info_ptr)
-               *info_ptr = info;
-       if (handle_ptr)
-               *handle_ptr = obj;
+       *info_ptr = info;
+       *handle_ptr = obj;
 
        return ret;
 failure: