fm10k: reduce the scope of the local i variable
authorJacob Keller <jacob.e.keller@intel.com>
Mon, 8 Jul 2019 23:12:25 +0000 (16:12 -0700)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Thu, 1 Aug 2019 21:50:19 +0000 (14:50 -0700)
Reduce the scope of the local loop variable in the
fm10k_check_hang_subtask function.

This was detected by cppcheck and resolves the following warning
produced by that tool:

[driver/fm10k_pci.c:852]: (style) The scope of the variable 'i' can be
reduced.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/fm10k/fm10k_pci.c

index 9421832c248051535861b5a0ca5565d97e30bdc3..9522e9f8f8b8d3915a535ed2102cf3bd267c0aa9 100644 (file)
@@ -698,8 +698,6 @@ static void fm10k_watchdog_subtask(struct fm10k_intfc *interface)
  */
 static void fm10k_check_hang_subtask(struct fm10k_intfc *interface)
 {
-       int i;
-
        /* If we're down or resetting, just bail */
        if (test_bit(__FM10K_DOWN, interface->state) ||
            test_bit(__FM10K_RESETTING, interface->state))
@@ -711,6 +709,8 @@ static void fm10k_check_hang_subtask(struct fm10k_intfc *interface)
        interface->next_tx_hang_check = jiffies + (2 * HZ);
 
        if (netif_carrier_ok(interface->netdev)) {
+               int i;
+
                /* Force detection of hung controller */
                for (i = 0; i < interface->num_tx_queues; i++)
                        set_check_for_tx_hang(interface->tx_ring[i]);