usb: dwc3: gadget: move requests to cancelled_list
authorFelipe Balbi <felipe.balbi@linux.intel.com>
Wed, 1 Aug 2018 10:54:25 +0000 (13:54 +0300)
committerFelipe Balbi <felipe.balbi@linux.intel.com>
Mon, 26 Nov 2018 07:08:29 +0000 (09:08 +0200)
Whenever we have a request in flight, we can move it to the cancelled
list and later simply iterate over that list and skip over any TRBs we
find.

Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
drivers/usb/dwc3/gadget.c

index 17203944d77f7fda7f566b508f6d11d649da2337..d5b9db90ca1c4d09a49d03cc8cd9864ed99be34d 100644 (file)
@@ -1498,6 +1498,17 @@ static void dwc3_gadget_ep_skip_trbs(struct dwc3_ep *dep, struct dwc3_request *r
        }
 }
 
+static void dwc3_gadget_ep_cleanup_cancelled_requests(struct dwc3_ep *dep)
+{
+       struct dwc3_request             *req;
+       struct dwc3_request             *tmp;
+
+       list_for_each_entry_safe(req, tmp, &dep->cancelled_list, list) {
+               dwc3_gadget_ep_skip_trbs(dep, req);
+               dwc3_gadget_giveback(dep, req, -ECONNRESET);
+       }
+}
+
 static int dwc3_gadget_ep_dequeue(struct usb_ep *ep,
                struct usb_request *request)
 {
@@ -1534,8 +1545,9 @@ static int dwc3_gadget_ep_dequeue(struct usb_ep *ep,
                        if (!r->trb)
                                goto out0;
 
-                       dwc3_gadget_ep_skip_trbs(dep, r);
-                       goto out1;
+                       dwc3_gadget_move_cancelled_request(req);
+                       dwc3_gadget_ep_cleanup_cancelled_requests(dep);
+                       goto out0;
                }
                dev_err(dwc->dev, "request %pK was not queued to %s\n",
                                request, ep->name);
@@ -1543,7 +1555,6 @@ static int dwc3_gadget_ep_dequeue(struct usb_ep *ep,
                goto out0;
        }
 
-out1:
        dwc3_gadget_giveback(dep, req, -ECONNRESET);
 
 out0: