r8169: fix DMA issue on MIPS platform
authorHeiner Kallweit <hkallweit1@gmail.com>
Fri, 23 Aug 2019 18:07:26 +0000 (20:07 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 23 Aug 2019 22:10:50 +0000 (15:10 -0700)
As reported by Aaro this patch causes network problems on
MIPS Loongson platform. Therefore revert it.

Fixes: f072218cca5b ("r8169: remove not needed call to dma_sync_single_for_device")
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reported-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/realtek/r8169_main.c

index 910944120a6588d3e80f9701467e1367ab8f8637..6182e7d33e014cf5ad184bb0beb4c73d2bf67889 100644 (file)
@@ -5822,6 +5822,10 @@ process_pkt:
                        skb->tail += pkt_size;
                        skb->len = pkt_size;
 
+                       dma_sync_single_for_device(tp_to_dev(tp),
+                                                  le64_to_cpu(desc->addr),
+                                                  pkt_size, DMA_FROM_DEVICE);
+
                        rtl8169_rx_csum(skb, status);
                        skb->protocol = eth_type_trans(skb, dev);