isdn: hisax: Fix pnp_irq's error checking for setup_sedlbauer_isapnp
authorArvind Yadav <arvind.yadav.cs@gmail.com>
Thu, 16 Nov 2017 04:27:28 +0000 (09:57 +0530)
committerDavid S. Miller <davem@davemloft.net>
Thu, 16 Nov 2017 13:31:16 +0000 (22:31 +0900)
The pnp_irq() function returns -1 if an error occurs.
pnp_irq() error checking for zero is not correct.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/isdn/hisax/sedlbauer.c

index f16a47bcef485cc41dcf688e2d87a48ef1b7aa87..c0b97b893495a77332d7a8fc13d7fc41803b5c4d 100644 (file)
@@ -558,7 +558,7 @@ static int setup_sedlbauer_isapnp(struct IsdnCard *card, int *bytecnt)
                                card->para[1] = pnp_port_start(pnp_d, 0);
                                card->para[0] = pnp_irq(pnp_d, 0);
 
-                               if (!card->para[0] || !card->para[1]) {
+                               if (card->para[0] == -1 || !card->para[1]) {
                                        printk(KERN_ERR "Sedlbauer PnP:some resources are missing %ld/%lx\n",
                                               card->para[0], card->para[1]);
                                        pnp_disable_dev(pnp_d);