regulator: max77650: Fix set_current_limit implementation
authorAxel Lin <axel.lin@ingics.com>
Fri, 22 Feb 2019 09:09:21 +0000 (17:09 +0800)
committerMark Brown <broonie@kernel.org>
Fri, 22 Feb 2019 15:16:33 +0000 (15:16 +0000)
Current code always return error, fix it.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/max77650-regulator.c

index 411912d5278b1194df0971f060bf160b656e08e0..a1af414db7513fa8cae18573919592bba751474c 100644 (file)
@@ -243,7 +243,7 @@ static int max77650_regulator_set_current_limit(struct regulator_dev *rdev,
 {
        struct max77650_regulator_desc *rdesc;
        struct regmap *map;
-       int rv, i, limit;
+       int i, limit;
 
        rdesc = rdev_get_drvdata(rdev);
        map = rdev_get_regmap(rdev);
@@ -252,11 +252,9 @@ static int max77650_regulator_set_current_limit(struct regulator_dev *rdev,
                limit = max77650_current_limit_table[i];
 
                if (limit >= min_uA && limit <= max_uA) {
-                       rv = regmap_update_bits(map, rdesc->regA,
+                       return regmap_update_bits(map, rdesc->regA,
                                        MAX77650_REGULATOR_CURR_LIM_MASK,
                                        MAX77650_REGULATOR_CURR_LIM_SHIFT(i));
-                       if (rv)
-                               return rv;
                }
        }