cpufreq: ap806: add missing of_node_put after of_device_is_available
authorJulia Lawall <Julia.Lawall@lip6.fr>
Sat, 23 Feb 2019 13:20:41 +0000 (14:20 +0100)
committerViresh Kumar <viresh.kumar@linaro.org>
Mon, 25 Feb 2019 04:29:15 +0000 (09:59 +0530)
Add an of_node_put when a tested device node is not available.

The semantic patch that fixes this problem is as follows
(http://coccinelle.lip6.fr):

// <smpl>
@@
identifier f;
local idexpression e;
expression x;
@@

e = f(...);
... when != of_node_put(e)
    when != x = e
    when != e = x
    when any
if (<+...of_device_is_available(e)...+>) {
  ... when != of_node_put(e)
(
  return e;
|
+ of_node_put(e);
  return ...;
)
}
// </smpl>

Fixes: f525a670533d9 ("cpufreq: ap806: add cpufreq driver for Armada 8K")
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
drivers/cpufreq/armada-8k-cpufreq.c

index 8a5ddb93fc58d24cf7cb88639c17e81e1bb382b7..b3f4bd647e9b39792228df4c0d8589545e4dae9a 100644 (file)
@@ -128,8 +128,10 @@ static int __init armada_8k_cpufreq_init(void)
        struct cpumask cpus;
 
        node = of_find_compatible_node(NULL, NULL, "marvell,ap806-cpu-clock");
-       if (!node || !of_device_is_available(node))
+       if (!node || !of_device_is_available(node)) {
+               of_node_put(node);
                return -ENODEV;
+       }
 
        nb_cpus = num_possible_cpus();
        freq_tables = kcalloc(nb_cpus, sizeof(*freq_tables), GFP_KERNEL);