staging: sm7xxfb: copy device name before we pass to the smtc_alloc_fb_info
authorDevendra Naga <devendra.aaru@gmail.com>
Sun, 26 Aug 2012 06:27:16 +0000 (11:57 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 4 Sep 2012 21:23:33 +0000 (14:23 -0700)
the name is not initialised and passed to the function smtc_alloc_fb_info
and copies the name into a member of fb structure.

copy the name before calling alloc_fb_info.

Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Acked-by: Javier Muñoz <jmunhoz@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/sm7xxfb/sm7xxfb.c

index 1c1780c70fbb2374abdb834a49813d92691f45b4..d935c23456e8b053bb8ea024e02292e96311a2cd 100644 (file)
@@ -798,6 +798,8 @@ static int __devinit smtcfb_pci_probe(struct pci_dev *pdev,
        if (err)
                return err;
 
+       sprintf(name, "sm%Xfb", ent->device);
+
        sfb = smtc_alloc_fb_info(pdev, name);
 
        if (!sfb) {
@@ -806,7 +808,6 @@ static int __devinit smtcfb_pci_probe(struct pci_dev *pdev,
        }
 
        sfb->chip_id = ent->device;
-       sprintf(name, "sm%Xfb", sfb->chip_id);
 
        pci_set_drvdata(pdev, sfb);