net/sched: flower: Dump the ethertype encapsulated in vlan
authorJianbo Liu <jianbol@mellanox.com>
Fri, 6 Jul 2018 05:38:15 +0000 (05:38 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sat, 7 Jul 2018 11:51:53 +0000 (20:51 +0900)
Currently the encapsulated ethertype is not dumped as it's the same as
TCA_FLOWER_KEY_ETH_TYPE keyvalue. But the dumping result is inconsistent
with input, we add dumping it with TCA_FLOWER_KEY_VLAN_ETH_TYPE.

Signed-off-by: Jianbo Liu <jianbol@mellanox.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/cls_flower.c

index da9ec30763feaf4600de0fe546d2e1e0e60a8a5c..e93b13d2cb81de277a5e4fa6d7653457e448471b 100644 (file)
@@ -1313,6 +1313,10 @@ static int fl_dump(struct net *net, struct tcf_proto *tp, void *fh,
        if (fl_dump_key_vlan(skb, &key->vlan, &mask->vlan))
                goto nla_put_failure;
 
+       if (mask->vlan.vlan_tpid &&
+           nla_put_be16(skb, TCA_FLOWER_KEY_VLAN_ETH_TYPE, key->basic.n_proto))
+               goto nla_put_failure;
+
        if ((key->basic.n_proto == htons(ETH_P_IP) ||
             key->basic.n_proto == htons(ETH_P_IPV6)) &&
            (fl_dump_key_val(skb, &key->basic.ip_proto, TCA_FLOWER_KEY_IP_PROTO,