inet: frags: use INC_STATS_BH in the ipv6 reassembly code
authorNikolay Aleksandrov <nikolay@redhat.com>
Fri, 1 Aug 2014 10:29:43 +0000 (12:29 +0200)
committerDavid S. Miller <davem@davemloft.net>
Sat, 2 Aug 2014 22:31:31 +0000 (15:31 -0700)
Softirqs are already disabled so no need to do it again, thus let's be
consistent and use the IP6_INC_STATS_BH variant.

Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com>
Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/reassembly.c

index f1709c4a289a5802c1c1baa03bd9d87193b3b589..512ccc027ce35228fb1b2dff5068026bce57b8e9 100644 (file)
@@ -355,8 +355,8 @@ found:
 discard_fq:
        inet_frag_kill(&fq->q, &ip6_frags);
 err:
-       IP6_INC_STATS(net, ip6_dst_idev(skb_dst(skb)),
-                     IPSTATS_MIB_REASMFAILS);
+       IP6_INC_STATS_BH(net, ip6_dst_idev(skb_dst(skb)),
+                        IPSTATS_MIB_REASMFAILS);
        kfree_skb(skb);
        return -1;
 }
@@ -566,7 +566,8 @@ static int ipv6_frag_rcv(struct sk_buff *skb)
        return -1;
 
 fail_hdr:
-       IP6_INC_STATS(net, ip6_dst_idev(skb_dst(skb)), IPSTATS_MIB_INHDRERRORS);
+       IP6_INC_STATS_BH(net, ip6_dst_idev(skb_dst(skb)),
+                        IPSTATS_MIB_INHDRERRORS);
        icmpv6_param_prob(skb, ICMPV6_HDR_FIELD, skb_network_header_len(skb));
        return -1;
 }