igb: Fix master/slave mode for all m88 i354 PHY's
authorCarolyn Wyborny <carolyn.wyborny@intel.com>
Fri, 16 Aug 2013 00:39:10 +0000 (00:39 +0000)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Thu, 24 Oct 2013 12:41:20 +0000 (05:41 -0700)
This patch calls code to set the master/slave mode for all m88 gen 2
PHY's. This patch also removes the call to this function for I210 devices
only from the function that is not called by I210 devices.

Signed-off-by: Carolyn Wyborny <carolyn.wyborny@intel.com>
Tested-by: Jeff Pieper <jeffrey.e.pieper@gmail.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/igb/e1000_phy.c

index e7266759a10bb116c1da8d8b7c4c9e5aa399c65c..c4c4fe332c7ee06af09696cc8e5ba027d6d9ba15 100644 (file)
@@ -708,11 +708,6 @@ s32 igb_copper_link_setup_m88(struct e1000_hw *hw)
                hw_dbg("Error committing the PHY changes\n");
                goto out;
        }
-       if (phy->type == e1000_phy_i210) {
-               ret_val = igb_set_master_slave_mode(hw);
-               if (ret_val)
-                       return ret_val;
-       }
 
 out:
        return ret_val;
@@ -806,6 +801,9 @@ s32 igb_copper_link_setup_m88_gen2(struct e1000_hw *hw)
                hw_dbg("Error committing the PHY changes\n");
                return ret_val;
        }
+       ret_val = igb_set_master_slave_mode(hw);
+       if (ret_val)
+               return ret_val;
 
        return 0;
 }