ath10k: fix bug in masking of TID value

Although the TID mask is 0xf, the modulus operation does still not
produce identical results as the bitwise and operator. If the TID is 15, the
modulus operation will "convert" it to 0, whereas the bitwise and will keep it
as 15.

This was found during code review.

Signed-off-by: Erik Stromdahl <erik.stromdahl@gmail.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

diff --git a/drivers/net/wireless/ath/ath10k/htt_tx.c b/drivers/net/wireless/ath/ath10k/htt_tx.c
index 89157c5b5e5fd0771d5be58bb81cba168ffd59aa..be5b52aaffa61c2aa1f2ebaf0ec74042cc5d81c9 100644 (file)
--- a/drivers/net/wireless/ath/ath10k/htt_tx.c
+++ b/drivers/net/wireless/ath/ath10k/htt_tx.c
@@ -1056,7 +1056,7 @@ static u8 ath10k_htt_tx_get_tid(struct sk_buff *skb, bool is_eth)
        if (!is_eth && ieee80211_is_mgmt(hdr->frame_control))
                return HTT_DATA_TX_EXT_TID_MGMT;
        else if (cb->flags & ATH10K_SKB_F_QOS)
-               return skb->priority % IEEE80211_QOS_CTL_TID_MASK;
+               return skb->priority & IEEE80211_QOS_CTL_TID_MASK;
        else
                return HTT_DATA_TX_EXT_TID_NON_QOS_MCAST_BCAST;
 }