kprobes: Remove pointless BUG_ON() from disarming process
authorMasami Hiramatsu <mhiramat@kernel.org>
Tue, 11 Sep 2018 10:19:14 +0000 (19:19 +0900)
committerIngo Molnar <mingo@kernel.org>
Wed, 12 Sep 2018 06:01:15 +0000 (08:01 +0200)
All aggr_probes at this line are already disarmed by
disable_kprobe() or checked by kprobe_disarmed().

So this BUG_ON() is pointless, remove it.

Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>
Cc: David S . Miller <davem@davemloft.net>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Naveen N . Rao <naveen.n.rao@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/153666115463.21306.8799008438116029806.stgit@devbox
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/kprobes.c

index ab257be4d92495a52c780d45c519eea608225c9e..d1edd8d5641ecf6e81f9d2d64f00fd47c452de5c 100644 (file)
@@ -1704,7 +1704,6 @@ noclean:
        return 0;
 
 disarmed:
-       BUG_ON(!kprobe_disarmed(ap));
        hlist_del_rcu(&ap->hlist);
        return 0;
 }