bnx2x: add missing parenthesis to prevent u32 overflow
authorDmitry Kravkov <dmitry@broadcom.com>
Wed, 4 Apr 2012 02:27:42 +0000 (02:27 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 4 Apr 2012 22:03:45 +0000 (18:03 -0400)
Commit b475d78 lacked two pairs of parenthesis, causing an overflow in the
congestion management.

Signed-off-by: Dmitry Kravkov <dmitry@broadcom.com>
Signed-off-by: Yuval Mintz <yuvalmin@broadcom.com>
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnx2x/bnx2x_init.h

index e6bb9f4c619c6b416d7531d47709f9f9b190661c..2b7a2bd0592c5962325bd7592a281aeb6554e153 100644 (file)
@@ -409,7 +409,7 @@ static inline void bnx2x_init_min(const struct cmng_init_input *input_data,
                         */
                        vdata->vnic_min_rate[vnic].vn_credit_delta =
                                (u32)input_data->vnic_min_rate[vnic] * 100 *
-                               T_FAIR_COEF / (8 * 100 * vnicWeightSum);
+                               (T_FAIR_COEF / (8 * 100 * vnicWeightSum));
                        if (vdata->vnic_min_rate[vnic].vn_credit_delta <
                            pdata->fair_vars.fair_threshold +
                            MIN_ABOVE_THRESH) {
@@ -446,7 +446,7 @@ static inline void bnx2x_init_fw_wrr(const struct cmng_init_input *input_data,
                                 */
                                ccd[cos] =
                                    (u32)input_data->cos_min_rate[cos] * 100 *
-                                   T_FAIR_COEF / (8 * 100 * cosWeightSum);
+                                   (T_FAIR_COEF / (8 * 100 * cosWeightSum));
                                 if (ccd[cos] < pdata->fair_vars.fair_threshold
                                                + MIN_ABOVE_THRESH) {
                                        ccd[cos] =